Add a warning when an entry provided with "--classpath" does not exists#330
Open
jmini wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Open
Add a warning when an entry provided with "--classpath" does not exists#330jmini wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
jmini wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
akerekes
requested changes
Oct 6, 2025
| urls.addAll(jarsIn(component.substring(0, component.length() - 2))); | ||
| } else { | ||
| Path path = Paths.get(component); | ||
| if(!Files.isRegularFile(path)) { |
Contributor
There was a problem hiding this comment.
This will emit the warning on existing directories.
Author
|
@akerekes any inputs on how the test |
Contributor
|
@jmini would an approach like https://stackoverflow.com/a/1828268 work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I lost a lot of time because I had a typo in the jar listed as
--classpathvalue when running the command:I think it would make sense to add a warning to help users (like me) realizing they added an invalid entry on the list provided with
--classpath.